Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get rid of "unused parameter ‘sensor_configuration’" warning for Velodyne #99

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: get rid of "unused parameter ‘sensor_configuration’" warning for Velodyne #99

merged 1 commit into from
Dec 5, 2023

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Nov 27, 2023

PR Type

  • Bug Fix

Related Links

Description

This PR fixes the unused parameter ‘sensor_configuration’ warning when building nebula_hw_interfaces.
The parameter was unused because it was of type SensorConfigurationBase while the function in question needed VelodyneSensorConfiguration and used the member variable of the correct type, ignoring the parameter.

The member now gets updated with the casted parameter value.

Review Procedure

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex requested a review from drwnz November 27, 2023 09:03
@mojomex mojomex self-assigned this Nov 27, 2023
@mojomex mojomex requested a review from amc-nu November 27, 2023 09:03
@mojomex mojomex force-pushed the fix-unused-sensor-configuration-velodyne branch from f2a6e74 to b42fa30 Compare December 5, 2023 05:10
@mojomex
Copy link
Collaborator Author

mojomex commented Dec 5, 2023

Verified working

This PR is ready for review/merging. I tested the following procedures on VLP32:

Test Verification Worked?
Launch using the nebula_launch.py file, with various return modes Visualize return mode in Rviz 🟢
Launch using velodyne_launch_all_hw.xml with various return modes = 🟢
Launch using velodyne_launch_all_hw.xml with various scan angles Visualize timestamp in Rviz 🟢
Set return mode via ros2 param set velodyne_hw_interface_ros_wrapper return_mode <return_mode> visualize return mode in Rviz, look for console errors 🟢

The compiler warning for the unused parameter is also gone of course.

drwnz
drwnz approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drwnz drwnz merged commit a1a2290 into tier4:main Dec 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwnz drwnz drwnz approved these changes

@amc-nu amc-nu Awaiting requested review from amc-nu

Assignees

@mojomex mojomex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mojomex @drwnz